Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LLVM patch D65174 to fix a compiler performance regression #35262

Merged
merged 2 commits into from
Mar 28, 2020

Conversation

JeffBezanson
Copy link
Member

No description provided.

@vchuravy
Copy link
Member

After the BB bump I can do the backport to 1.4

@vchuravy
Copy link
Member

Did you test that the patch for LLVM8 applies cleanly? I was applying in JuliaPackaging/Yggdrasil#658 and it seems to fail.

@JeffBezanson
Copy link
Member Author

I don't believe any released version of julia uses LLVM 8, so I'd be fine just not supporting the patch there.

@KristofferC
Copy link
Member

1.4 uses LLVM 8 right?

@vchuravy
Copy link
Member

This should be good to go, and I will handle the backport to 1.4

@vchuravy vchuravy requested a review from staticfloat March 26, 2020 22:29
@JeffBezanson
Copy link
Member Author

Oops, of course, for some reason I thought 1.4 was also LLVM 9. @vchuravy did you manage to port the patch to LLVM 8 or should I do it?

@vchuravy
Copy link
Member

Oops, of course, for some reason I thought 1.4 was also LLVM 9. @vchuravy did you manage to port the patch to LLVM 8 or should I do it?

I was planning to do it over the weekend since there is a second patch as well. Dealing with LLVM is a good cure of insomnia.

@vchuravy vchuravy merged commit b637cb7 into master Mar 28, 2020
@vchuravy vchuravy deleted the jb/storemergeperf branch March 28, 2020 19:29
@KristofferC KristofferC mentioned this pull request Apr 4, 2020
27 tasks
@KristofferC
Copy link
Member

KristofferC commented Apr 4, 2020

Backporting tracked in #35313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:latency Compiler latency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants